feat(react-kit): email otp authentication flow#100
Merged
Conversation
OmarBasem
changed the title
OmarBasem
changed the title
OmarBasem
commented
Apr 15, 2026
Comment on lines
+29
to
37
| const handleVerify = async () => { | ||
| if (!otp.trim() || !otpId) return | ||
|
|
||
| setError(false) | ||
| try { | ||
| await verifyOtp({ otpId, code }) | ||
| await verifyOtp({ otpId, code: otp.trim() }) | ||
| goToStep('authenticated') | ||
| config?.onSuccess?.() | ||
| } catch (err) { |
Member
Author
There was a problem hiding this comment.
I am wondering if we need the Verifying screen for the manual otp flow, we can verify the otp on the same screen as shown in the demo video
Collaborator
There was a problem hiding this comment.
Yeah I think it's better if we remove the screen itself now and verify on the same screen.
Member
Author
There was a problem hiding this comment.
@brtkx I think we can keep it for magic link?
OmarBasem
force-pushed
the
omar/email-verification
branch
from
028cc7b to
dbae517
Compare
OmarBasem
force-pushed
the
omar/sign-up-page
branch
from
13e5d05 to
8a256ca
Compare
OmarBasem
force-pushed
the
omar/email-verification
branch
from
dbae517 to
6bce2fe
Compare
OmarBasem
force-pushed
the
omar/sign-up-page
branch
2 times, most recently
from
053ca18 to
40004db
Compare
OmarBasem
force-pushed
the
omar/email-verification
branch
from
6bce2fe to
1f59081
Compare
OmarBasem
force-pushed
the
omar/sign-up-page
branch
from
40004db to
cc5d328
Compare
OmarBasem
force-pushed
the
omar/email-verification
branch
from
1f59081 to
3d69c8c
Compare
OmarBasem
force-pushed
the
omar/sign-up-page
branch
from
cc5d328 to
949aaca
Compare
OmarBasem
force-pushed
the
omar/email-verification
branch
from
3d69c8c to
fc89cf5
Compare
OmarBasem
force-pushed
the
omar/sign-up-page
branch
from
949aaca to
a926391
Compare
OmarBasem
force-pushed
the
omar/email-verification
branch
2 times, most recently
from
6bd5e27 to
5538f07
Compare
# Conflicts: # packages/react-kit/src/shared/components/AppLogo/AppLogo.test.tsx
OmarBasem
force-pushed
the
omar/email-verification
branch
from
5538f07 to
66e517e
Compare
brtkx
reviewed
Apr 22, 2026
Comment on lines
+29
to
37
| const handleVerify = async () => { | ||
| if (!otp.trim() || !otpId) return | ||
|
|
||
| setError(false) | ||
| try { | ||
| await verifyOtp({ otpId, code }) | ||
| await verifyOtp({ otpId, code: otp.trim() }) | ||
| goToStep('authenticated') | ||
| config?.onSuccess?.() | ||
| } catch (err) { |
Collaborator
There was a problem hiding this comment.
Yeah I think it's better if we remove the screen itself now and verify on the same screen.
| }, | ||
| } | ||
|
|
||
| export const FourDigits: Story = { |
Collaborator
There was a problem hiding this comment.
Why are we removing the length prop?
Member
Author
There was a problem hiding this comment.
Updated!
(I was thinking devs would be using our ZD backend which is using 6 digit code, but yeah keeping it dynamic makes sense anyways 👍 )
brtkx
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes FS-1958, FS-1961, FS-1962, FS-1959
Summary
This PR implements UI for the rest of the email otp auth flow
Demo
demo.mp4